fix: list keys output for empty keys#15876
Merged
julienrbrt merged 3 commits intocosmos:mainfrom Apr 19, 2023
Merged
Conversation
… breaking scripts that expect json output when requesting json output
ghost
requested review from
a team,
alexanderbez and
facundomedica
and removed request for
a team
julienrbrt
approved these changes
Apr 19, 2023
Contributor
julienrbrt
left a comment
julienrbrt
left a comment
There was a problem hiding this comment.
tACK.
Do you think it is worth fixing L47 as well to return a JSON with only the names?
Using the -n flag does not return a JSON (simd keys list -n --output json)
rdovgan
approved these changes
Apr 19, 2023
Contributor
|
I am going to merge this now. I let you open a follow-up PR if you think |
mergify bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
(cherry picked from commit 5948b38) # Conflicts: # CHANGELOG.md
julienrbrt
reviewed
Apr 19, 2023
| * (x/capability) [#15030](https://github.com/cosmos/cosmos-sdk/pull/15030) Prevent `x/capability` from consuming `GasMeter` gas during `InitMemStore` | ||
| * (types/coin) [#14739](https://github.com/cosmos/cosmos-sdk/pull/14739) Deprecate the method `Coin.IsEqual` in favour of `Coin.Equal`. The difference between the two methods is that the first one results in a panic when denoms are not equal. This panic lead to unexpected behavior | ||
| * (x/crypto) [#15258](https://github.com/cosmos/cosmos-sdk/pull/15258) Write keyhash file with permissions 0600 instead of 0555. | ||
| * (client/keys) [15867](https://github.com/cosmos/cosmos-sdk/pull/15876) Fix the output of the client keys query when there are no keys |
Contributor
There was a problem hiding this comment.
Updated the changelog wording here.
It is not significant on main, as this line will get deleted when we release v0.47.2.
julienrbrt
added a commit
that referenced
this pull request
Apr 19, 2023
roy-dydx
pushed a commit
to dydxprotocol/cosmos-sdk
that referenced
this pull request
Jul 11, 2023
…15894) Co-authored-by: Mantas Vidutis <mantas.a.vidutis@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that the expected output format is honored. this println is breaking scripts that expect json output when requesting json output
Description
A recent change caused listing of an empty key set to always print a response string to stdout. This means you can't structure scripts around the keys list query, as requesting json won't return json. This breaks existing code.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change