R4R: Terminate Update Bonded Validators Iteration Properly

[alexanderbez]

Terminate iteration loop in UpdateBondedValidators and UpdateBondedValidatorsFull when the first revoked validator is encountered and perform a sanity check.

closes: #1974

---

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
• Updated all relevant documentation (docs/)
• Updated all relevant code comments
• Wrote tests
• Added entries in PENDING.md that include links to the relevant issue or PR that most accurately describes the change.
• Updated cmd/gaia and examples/

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #2023 into develop will increase coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop    #2023      +/-   ##
===========================================
+ Coverage    64.86%   64.86%   +<.01%     
===========================================
  Files          115      115              
  Lines         6862     6863       +1     
===========================================
+ Hits          4451     4452       +1     
  Misses        2127     2127              
  Partials       284      284

[cwgoes]

utACK

[cwgoes]

Please don't squash each time, we can do that once when we merge to develop. I guess the PR checkboxes are confusing.

[alexanderbez]

@cwgoes you mean squash right after approvals but right before merge? If so, who does the squashing? Indeed, it's a bit confusing, but I agree nonetheless -- apologies.

[cwgoes]

@cwgoes you mean squash right after approvals but right before merge? If so, who does the squashing? Indeed, it's a bit confusing, but I agree nonetheless -- apologies.

The person who merges does the squashing; it's a button on the GitHub UI (or easy enough from a shell too).

[rigelrozanski]

reviewed - logic lookin' gud~!