Skip to content

simulation: rename TestAndRunTx to Operation, make timestamp randomized#2153

Merged
cwgoes merged 1 commit intodevelopfrom
dev/simulation_refactor
Aug 27, 2018
Merged

simulation: rename TestAndRunTx to Operation, make timestamp randomized#2153
cwgoes merged 1 commit intodevelopfrom
dev/simulation_refactor

Conversation

@ValarDragon
Copy link
Copy Markdown
Contributor

@ValarDragon ValarDragon commented Aug 27, 2018

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Wrote tests - covered under default tests

  • Added entries in PENDING.md with issue #


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ValarDragon ValarDragon force-pushed the dev/simulation_refactor branch from 19a469f to 4451755 Compare August 27, 2018 02:41
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 27, 2018

Codecov Report

Merging #2153 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2153   +/-   ##
========================================
  Coverage    63.91%   63.91%           
========================================
  Files          134      134           
  Lines         8194     8194           
========================================
  Hits          5237     5237           
  Misses        2604     2604           
  Partials       353      353

Copy link
Copy Markdown
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 🏎 🍰

Copy link
Copy Markdown
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 👍

@cwgoes cwgoes merged commit 9482c13 into develop Aug 27, 2018
@cwgoes cwgoes deleted the dev/simulation_refactor branch August 27, 2018 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants