R4R: Store Refactor by mossid · Pull Request #2344 · cosmos/cosmos-sdk

mossid · 2018-09-15T20:17:07Z

Closes: #2309

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (docs/)
Added entries in PENDING.md with issue #
rereviewed Files changed in the github PR explorer

Each store has moved to their own folder
Store related files, such as gas.go, store.go, are moved to store/
types/ imports store/ now and reexports types/functions
Remove StoreType enum, instead StoreKeys are dependent on concrete store implementation
Made some code duplication at errors.go to reduce dependency
traceWriter io.Writer and traceContext TraceContext are merged into Tracer
meter GasMeter and config GasConfig are merged into GasTank
Store interfaces are refactored:

            KVStore         CommitStore          MultiStore              ^
           /        \         /        \           /       \             |
         /            \     /            \       /          \            |  embeds
CacheKVStore    CommitKVStore    CommitMultiStore    CacheMultiStore     *

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

codecov · 2018-09-16T17:16:02Z

Codecov Report

Merging #2344 into develop will decrease coverage by 0.3%.
The diff coverage is 70.77%.

@@             Coverage Diff             @@
##           develop    #2344      +/-   ##
===========================================
- Coverage    58.82%   58.51%   -0.31%     
===========================================
  Files          152      144       -8     
  Lines         9425     8213    -1212     
===========================================
- Hits          5544     4806     -738     
+ Misses        3511     3091     -420     
+ Partials       370      316      -54

cwgoes · 2018-10-25T13:23:39Z

@mossid Do you want to rebase this? I still think the refactor is a great idea and would be happy to review (sorry it didn't happen sooner)!

cwgoes · 2018-11-01T12:59:22Z

@mossid Thanks for rebasing. Let's pair review this in person, maybe early next week.

alexanderbez

@mossid this PR is pretty hefty...I really don't know how to start as I'm sure I'll miss something. May I suggest perhaps breaking it up into sub PR (I, II, III, etc...) if possible?

Thoughts @ValarDragon?

alexanderbez · 2018-11-01T19:48:30Z

baseapp/baseapp.go

 // CommitMultiStore.
 func (app *BaseApp) SetCommitMultiStoreTracer(w io.Writer) {
-	app.cms.WithTracer(w)
+	app.cms.GetTracer().Writer = w


The initial API call was bad and that's my fault. Can we just do app.cms.SetTracer(w)?

alexanderbez · 2018-11-01T19:50:10Z

cmd/gaia/app/app.go

-	keyMain          *sdk.KVStoreKey
-	keyAccount       *sdk.KVStoreKey
-	keyStake         *sdk.KVStoreKey
+	keyMain          *sdk.IAVLStoreKey


Mhmmm, why did we rename these? This assumes IAVL usage, although it probably won't change for Gaia.

I don't want us to have this key... an IAVLStore is a KVStore... no need to create key types for specific types of KVStores. In the future we may have other store types like HeapStores.

fedekunze · 2018-11-08T22:28:12Z

lol this PR is gigantic

rigelrozanski · 2018-11-29T01:14:36Z

@mossid way out of date - please update, we should get this in

mossid · 2018-12-03T19:18:50Z

Closing in favor of #2986

mossid added the wip label Sep 15, 2018

mossid requested review from cwgoes, ebuchman and rigelrozanski as code owners September 15, 2018 20:17

cwgoes self-assigned this Oct 3, 2018

mossid changed the title ~~WIP: Store Refactor~~ R4R: Store Refactor Oct 3, 2018

mossid added ready-for-review and removed wip labels Oct 3, 2018

mossid force-pushed the joon/2309-store-refactor branch from a43b50f to 80a4921 Compare October 6, 2018 16:55

mossid changed the title ~~R4R: Store Refactor~~ WIP: Store Refactor Oct 7, 2018

mossid added wip and removed ready-for-review labels Oct 7, 2018

mossid force-pushed the joon/2309-store-refactor branch from db4905a to ab13269 Compare October 26, 2018 10:43

cwgoes mentioned this pull request Oct 28, 2018

R4R: Simulation improvements (logging fix, random genesis parameters) #2617

Merged

5 tasks

mossid requested a review from zramsay as a code owner October 29, 2018 17:19

mossid force-pushed the joon/2309-store-refactor branch from 218f495 to bc2b7f7 Compare October 29, 2018 18:16

sunnya97 changed the title ~~WIP: Store Refactor~~ R4R: Store Refactor Oct 30, 2018

sunnya97 added ready-for-review and removed wip labels Oct 30, 2018

mossid added 9 commits November 1, 2018 01:07

in progress

4f80b1f

finished moving stores to each folder, adding MountableStore

126cc99

refactor types/{store.go, gas.go}

e9e5d00

mv types/{gas.go, trace.go, store.go} to store/types/

9b0612e

move storekeys to each store

bd6217a

fix test in progress

51cbe59

now compiles

f0a915e

test passes

fd6e0f8

fix lint in progress

730f7d7

mossid and others added 11 commits November 1, 2018 01:07

finalize rebase

91656b2

fix test

05a2b46

fix lint

4677207

loadCommitStoreFromParams -> loadCommitKVStoreFromParams

698754f

distinguish KVStoreKey and MultiStoreKey, basemulti in progress

070ac7b

finalize rebase

155f945

make it compile again

5b80772

fix kvstore

c45005c

ci now passes

28d95ce

concrete key types on NewKeepers

0374f97

fixed lint

e1bd6dd

mossid force-pushed the joon/2309-store-refactor branch from 483ecfa to e1bd6dd Compare November 1, 2018 14:42

mossid added 2 commits November 1, 2018 17:34

fix syntax error

23f6ee7

fix syntax error

8da214e

alexanderbez reviewed Nov 1, 2018

View reviewed changes

cwgoes mentioned this pull request Nov 30, 2018

store Trace refactor #2824

Closed

mossid mentioned this pull request Dec 3, 2018

Store Refactor #2986

Closed

mossid closed this Dec 3, 2018

mossid deleted the joon/2309-store-refactor branch December 3, 2018 19:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

R4R: Store Refactor#2344

R4R: Store Refactor#2344
mossid wants to merge 22 commits intodevelopfrom
joon/2309-store-refactor

mossid commented Sep 15, 2018 •

edited

Loading

Uh oh!

codecov bot commented Sep 16, 2018 •

edited

Loading

Uh oh!

cwgoes commented Oct 25, 2018 •

edited

Loading

Uh oh!

cwgoes commented Nov 1, 2018

Uh oh!

alexanderbez left a comment

Uh oh!

alexanderbez Nov 1, 2018

Uh oh!

alexanderbez Nov 1, 2018

Uh oh!

jaekwon Nov 5, 2018

Uh oh!

fedekunze commented Nov 8, 2018

Uh oh!

rigelrozanski commented Nov 29, 2018 •

edited

Loading

Uh oh!

mossid commented Dec 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

mossid commented Sep 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cwgoes commented Oct 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cwgoes commented Nov 1, 2018

Uh oh!

alexanderbez left a comment

Choose a reason for hiding this comment

Uh oh!

alexanderbez Nov 1, 2018

Choose a reason for hiding this comment

Uh oh!

alexanderbez Nov 1, 2018

Choose a reason for hiding this comment

Uh oh!

jaekwon Nov 5, 2018

Choose a reason for hiding this comment

Uh oh!

fedekunze commented Nov 8, 2018

Uh oh!

rigelrozanski commented Nov 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mossid commented Dec 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mossid commented Sep 15, 2018 •

edited

Loading

codecov bot commented Sep 16, 2018 •

edited

Loading

cwgoes commented Oct 25, 2018 •

edited

Loading

rigelrozanski commented Nov 29, 2018 •

edited

Loading