R4R: Fix Quoted JSON Return

[jackzampolin]

Fixes: #2470

cc @faboweb @fedekunze @sabau

[codecov]

Codecov Report

Merging #3045 into develop will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           develop    #3045   +/-   ##
========================================
  Coverage    52.17%   52.17%           
========================================
  Files          136      136           
  Lines         9626     9626           
========================================
  Hits          5022     5022           
  Misses        4267     4267           
  Partials       337      337

[faboweb]

Nice! Could you add a test for this response?

[jackzampolin]

This is actually a bit difficult to test for right now because in our LCD tests we create an address to initialize the chain and don't have a running LCD with empty keys at any time:

	name, password := "test", "1234567890"
	addr, seed := CreateAddr(t, "test", password, GetKeyBase(t))
	cleanup, _, _, port := InitializeTestLCD(t, 1, []sdk.AccAddress{addr})
	defer cleanup()

Is it OK if I don't @faboweb

[faboweb]

Couldn't you just delete the one (main) key? A new key should be generated for the next test I assume?

[jackzampolin]

@faboweb that key runs the validator which is running the chain. I can dive deep here, but will take longer to fix. Or @fedekunze might be able to help me add this easily.

[alexanderbez]

I think this is fine for now, but please fix merge conflicts 👍

[cwgoes]

ACK