R4R: allow multiple simultaneous redelegations/ubds between same delegator/validator(s) addresses#3243
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3243 +/- ##
===========================================
- Coverage 55.65% 55.64% -0.01%
===========================================
Files 134 134
Lines 9716 9746 +30
===========================================
+ Hits 5407 5423 +16
- Misses 3965 3980 +15
+ Partials 344 343 -1 |
| // perform slashing on all entries within the unbonding delegation | ||
| for i, entry := range unbondingDelegation.Entries { | ||
|
|
||
| if unbondingDelegation.MinTime.Before(now) { |
There was a problem hiding this comment.
Note this subtle change of this line to instead use of entry.IsMature(now) - previously a delegation would have been slashed if it was at MinTime (which is a bit of an ambiguous name supposed to represent "min time to completion"). Under the updates the delegation will not be slashed if now==completionTime (rename from MinTime) as this would be considered a mature bond.
| return sdk.ZeroInt() | ||
| } | ||
|
|
||
| if redelegation.MinTime.Before(now) { |
There was a problem hiding this comment.
same subtle change as previously mentioned
cwgoes
left a comment
There was a problem hiding this comment.
Mostly LGTM, tests look fine, one minor comment. We can delete ErrConflictingRedelegation in x/stake/types/errors.go.
alexanderbez
left a comment
There was a problem hiding this comment.
Left a few minor comments, but the changes look reasonable to me :)
Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>
…smos-sdk into rigel/delegation-index
closes #1402
follow up ref issue: #3270
docs/) - more major doc updates to come during spec upgradePENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: