R4R: Add missing iterator close#3387
Merged
cwgoes merged 1 commit intocosmos:developfrom Jan 25, 2019
HaoyangLiu:irisnet/add-missing-iterator-close
Merged
R4R: Add missing iterator close#3387cwgoes merged 1 commit intocosmos:developfrom HaoyangLiu:irisnet/add-missing-iterator-close
cwgoes merged 1 commit intocosmos:developfrom
HaoyangLiu:irisnet/add-missing-iterator-close
Conversation
HaoyangLiu
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
HaoyangLiu
commented
Jan 25, 2019
| // Iterate over validators, highest power to lowest. | ||
| iterator := sdk.KVStoreReversePrefixIterator(store, ValidatorsByPowerIndexKey) | ||
| defer iterator.Close() | ||
| count := 0 |
Author
There was a problem hiding this comment.
The iterator will be created in every endBlocker. This missing may cause huge memory leak.
Codecov Report
@@ Coverage Diff @@
## develop #3387 +/- ##
===========================================
+ Coverage 59.32% 59.32% +<.01%
===========================================
Files 131 131
Lines 9855 9862 +7
===========================================
+ Hits 5846 5851 +5
- Misses 3636 3638 +2
Partials 373 373 |
rigelrozanski
approved these changes
Jan 25, 2019
Contributor
rigelrozanski
left a comment
rigelrozanski
left a comment
There was a problem hiding this comment.
It would be good to build a CI utility to check for missing iterator close statements
cwgoes
approved these changes
Jan 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.