Update docs get_vendor_deps -> vendor-deps#3402
Merged
jackzampolin merged 2 commits intodevelopfrom Jan 28, 2019
Merged
Conversation
gamarin2
requested review from
cwgoes,
ebuchman,
rigelrozanski and
zramsay
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #3402 +/- ##
===========================================
- Coverage 59.38% 59.32% -0.07%
===========================================
Files 131 131
Lines 9862 9862
===========================================
- Hits 5857 5851 -6
- Misses 3632 3638 +6
Partials 373 373 |
docs/gaia/installation.md
Outdated
| git clone https://github.com/cosmos/cosmos-sdk | ||
| cd cosmos-sdk && git checkout master | ||
| make tools && make get_vendor_deps && make install | ||
| make tools && make install |
Contributor
There was a problem hiding this comment.
Suggested change
| make tools && make install | |
| make tools vendor-deps install |
Contributor
There was a problem hiding this comment.
install depends on vendor-deps, this may be redundant.
docs/gaia/join-testnet.md
Outdated
| cd $GOPATH/src/github.com/cosmos/cosmos-sdk | ||
| git fetch --all && git checkout master | ||
| make update_tools && make get_vendor_deps && make install | ||
| make update_tools && make install |
Contributor
There was a problem hiding this comment.
Suggested change
| make update_tools && make install | |
| make update_tools vendor-deps install |
Contributor
|
Just a couple of small comment @gamarin2, then LGTM |
alessio
reviewed
Jan 27, 2019
alessio
reviewed
Jan 27, 2019
alessio
reviewed
Jan 27, 2019
Co-Authored-By: gamarin2 <gautier@tendermint.com>
jackzampolin
approved these changes
Jan 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace get_vendor_deps with vendor-deps in Makefile.