Merged
Conversation
jackzampolin
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
alessio
reviewed
Feb 5, 2019
alessio
reviewed
Feb 5, 2019
alessio
reviewed
Feb 5, 2019
client/utils/utils.go
Outdated
| } | ||
|
|
||
| // MessageOutput respects CLI flags and outputs a message | ||
| func MessageOutput(cliCtx context.CLIContext, txBldr authtxb.TxBuilder, msgs []sdk.Msg, offline bool) error { |
Contributor
There was a problem hiding this comment.
I reckon MessageOutput is a misnomer as it does not describe this function's main purpose. What this function does is actually executing the transaction according to the flags set in the context. As a side effect, it prints the response.
Contributor
Author
There was a problem hiding this comment.
What would you like this to be called?
Contributor
There was a problem hiding this comment.
HandleTxExecResponse? Dunno, it's a tricky one, though we'd better get it right now.
CC'ing @cwgoes @alexanderbez
Contributor
Author
There was a problem hiding this comment.
going to go with GenerateOrBroadcastMsgs per discussions with @alessio and @alexanderbez
alessio
reviewed
Feb 5, 2019
alessio
reviewed
Feb 5, 2019
Codecov Report
@@ Coverage Diff @@
## develop #3503 +/- ##
===========================================
- Coverage 52.99% 52.56% -0.44%
===========================================
Files 142 142
Lines 10363 10391 +28
===========================================
- Hits 5492 5462 -30
- Misses 4548 4600 +52
- Partials 323 329 +6 |
alessio
reviewed
Feb 5, 2019
alessio
reviewed
Feb 5, 2019
alessio
reviewed
Feb 5, 2019
alessio
reviewed
Feb 5, 2019
jackzampolin
force-pushed
the
jack/cli-args
branch
from
e692be7 to
fb1c9bf
Compare
alessio
approved these changes
Feb 6, 2019
alexanderbez
reviewed
Feb 7, 2019
| Read a transaction from [file_path] and broadcast it to a node. If you supply a dash (-) argument | ||
| in place of an input filename, the command reads from standard input. | ||
|
|
||
| $ gaiacli tx broadcast ./mytxn.json |
Contributor
There was a problem hiding this comment.
I'd prepend with Example or e.g. here.
| Short: "Query distribution validator commission", | ||
| Long: strings.TrimSpace(`Query validator commission rewards from delegators to that validator: | ||
|
|
||
| $ gaiacli query distr commission cosmosvaloper1gghjut3ccd8ay0zduzj64hwre2fxs9ldmqhffj |
| Short: "Query distribution validator slashes", | ||
| Long: strings.TrimSpace(`Query all slashes of a validator for a given block range: | ||
|
|
||
| $ gaiacli query distr slashes cosmosvaloper1gghjut3ccd8ay0zduzj64hwre2fxs9ldmqhffj 0 100 |
| Short: "Query all distribution delegator rewards or rewards from a particular validator", | ||
| Long: strings.TrimSpace(`Query all rewards earned by a delegator, optionally restrict to rewards from a single validator: | ||
|
|
||
| $ gaiacli query distr rewards cosmos1gghjut3ccd8ay0zduzj64hwre2fxs9ld75ru9p |
| var ( | ||
| flagOnlyFromValidator = "only-from-validator" | ||
| flagIsValidator = "is-validator" | ||
| flagComission = "comission" |
| Args: cobra.NoArgs, | ||
| Long: strings.TrimSpace(`Withdraw all rewards for a single delegator: | ||
|
|
||
| $ gaiacli tx distr withdraw-all-rewards --from mykey |
| Args: cobra.ExactArgs(1), | ||
| Long: strings.TrimSpace(`Set the withdraw address for rewards assoicated with a delegator address: | ||
|
|
||
| $ gaiacli tx set-withdraw-addr cosmos1gghjut3ccd8ay0zduzj64hwre2fxs9ld75ru9p --from mykey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @alessio and @alexanderbez
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: