Skip to content

Code cleanup, small coverage boost#3551

Merged
jackzampolin merged 1 commit intodevelopfrom
alessio/code-cleanup-plus-coverage-up
Feb 7, 2019
Merged

Code cleanup, small coverage boost#3551
jackzampolin merged 1 commit intodevelopfrom
alessio/code-cleanup-plus-coverage-up

Conversation

@alessio
Copy link
Copy Markdown
Contributor

@alessio alessio commented Feb 7, 2019

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2019

Codecov Report

Merging #3551 into develop will increase coverage by 2.93%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3551      +/-   ##
===========================================
+ Coverage     57.1%   60.03%   +2.93%     
===========================================
  Files          179      131      -48     
  Lines        14168     9640    -4528     
===========================================
- Hits          8090     5787    -2303     
+ Misses        5597     3509    -2088     
+ Partials       481      344     -137

Copy link
Copy Markdown
Contributor

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackzampolin jackzampolin merged commit dff6d0e into develop Feb 7, 2019
@jackzampolin jackzampolin deleted the alessio/code-cleanup-plus-coverage-up branch February 7, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants