R4R: General Sanitization & Gas Cost Review#3552
Merged
Conversation
Contributor
Author
|
@cwgoes @jackzampolin lmk if there are any other modifications to make or we deem necessary. |
cwgoes
approved these changes
Feb 8, 2019
jackzampolin
approved these changes
Feb 8, 2019
Contributor
jackzampolin
left a comment
There was a problem hiding this comment.
Has tests, feels good man 😎 👍
Codecov Report
@@ Coverage Diff @@
## develop #3552 +/- ##
===========================================
+ Coverage 57.24% 57.33% +0.08%
===========================================
Files 179 179
Lines 14105 14133 +28
===========================================
+ Hits 8075 8103 +28
+ Misses 5545 5544 -1
- Partials 485 486 +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(partially?) addresses #1008
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: