Conversation
jackzampolin
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Contributor
|
Fails |
cwgoes
suggested changes
Feb 8, 2019
Contributor
cwgoes
left a comment
cwgoes
left a comment
There was a problem hiding this comment.
One possible typo - that may be why CI is failing - otherwise LGTM.
x/auth/genesis.go
Outdated
| func InitGenesis(ctx sdk.Context, ak AccountKeeper, fck FeeCollectionKeeper, data GenesisState) { | ||
| ak.SetParams(ctx, data.Params) | ||
| fck.setCollectedFees(ctx, data.CollectedFees) | ||
| fck.setCollectedFees(ctx, sdk.Coins{}) |
Contributor
There was a problem hiding this comment.
This doesn't look intentional? We definitely want to set from genesis.
Codecov Report
@@ Coverage Diff @@
## develop #3554 +/- ##
===========================================
- Coverage 57.24% 57.14% -0.11%
===========================================
Files 179 179
Lines 14105 14135 +30
===========================================
+ Hits 8075 8077 +2
- Misses 5545 5578 +33
+ Partials 485 480 -5 |
cwgoes
approved these changes
Feb 8, 2019
alexanderbez
approved these changes
Feb 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the results of a code review of the
x/authandx/bankmodules by @sunnya97 and @jackzampolin