Skip to content

Ensure mint/inflation params respect flag supplied by the caller#3566

Merged
jackzampolin merged 1 commit intodevelopfrom
alessio/lcd-ensure-inflation-respects-bool-arg
Feb 9, 2019
Merged

Ensure mint/inflation params respect flag supplied by the caller#3566
jackzampolin merged 1 commit intodevelopfrom
alessio/lcd-ensure-inflation-respects-bool-arg

Conversation

@alessio
Copy link
Copy Markdown
Contributor

@alessio alessio commented Feb 9, 2019

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez
Copy link
Copy Markdown
Contributor

is this r4r @alessio?

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 9, 2019

Codecov Report

Merging #3566 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop   #3566      +/-   ##
==========================================
+ Coverage    61.38%   61.4%   +0.02%     
==========================================
  Files          185     185              
  Lines        13996   14006      +10     
==========================================
+ Hits          8591    8601      +10     
  Misses        4853    4853              
  Partials       552     552

@jackzampolin jackzampolin merged commit 360c7d2 into develop Feb 9, 2019
@jackzampolin jackzampolin deleted the alessio/lcd-ensure-inflation-respects-bool-arg branch February 9, 2019 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants