Merged
Conversation
Contributor
|
Concept ACK, we should do this sooner rather than later since it reduces the space of acceptable denoms. |
7b12bcb to
b498705
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3666 +/- ##
===========================================
- Coverage 61.39% 61.39% -0.01%
===========================================
Files 189 189
Lines 14098 14100 +2
===========================================
Hits 8656 8656
- Misses 4886 4888 +2
Partials 556 556 |
jackzampolin
approved these changes
Mar 1, 2019
Contributor
jackzampolin
left a comment
There was a problem hiding this comment.
I like this. Also agree with @cwgoes
alexanderbez
approved these changes
Mar 1, 2019
Contributor
|
Was the limit to 3 characters something that existed before this PR? Was there more reason than limiting the space of acceptable denoms? I'm trying to build an app with single char denoms rn and wondering if there's a good reason not to (besides forking the SDK 🍴) cc @ebuchman |
Contributor
|
Goes back even further: 2c1d533#diff-641f1d674d28f26344e36b61db7f47beL12 Probably it's to avoid people squatting smaller denoms and issues with readability/differentiation with less than 3 letters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: