R4R: Tagged docker images

[sabau]

I worked together with @greg-szabo into this process:

• release every new tag on docker hub
• two docker images with single entrypoint offered
• We will use two separate docker images as gaiacli can refer to a remote gaiad
• gaiali can scale and eventually be attacked while gaiad will keep live

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests n/a

• Updated relevant documentation (docs/)

• Added entries in PENDING.md with issue #

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[jackzampolin]

@sabau this is failing tests

[codecov]

Codecov Report

Merging #3694 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3694      +/-   ##
===========================================
+ Coverage    61.15%   61.17%   +0.01%     
===========================================
  Files          190      190              
  Lines        14008    14008              
===========================================
+ Hits          8567     8569       +2     
+ Misses        4905     4903       -2     
  Partials       536      536

[sabau]

Ok, rerunning fixed that

[sabau]

I removed the hashed version, in favour of the git tag version that will run only when a new tag will be added

[alessio]

Why not using git describe's output?

[sabau]

It seemed to me more readable to use $CIRCLE_TAG instead of getting the tag from a command.
In here the specific reason to change the behaviour was also to trigger the new job only when the tag is pushed.

[alessio]

It seemed to me more readable to use $CIRCLE_TAG instead of getting the tag from a command.

The risk is that versions may diverge. Did you check that gaiad version kinda looks like the image's actual version?

[cwgoes]

Thanks; a few notes:

• Needs PENDING.md
• Do we really need separate images for gaiacli / gaiad? Why not just one?
• Can we add instructions in documentation on how to use the Docker images?

[sabau]

Sure, documentation and pending will be added today, I'll remove the R4R until It's there.

The goal was to use them as commands so clients can get just the piece they need and use them as a single command. It should be easier to handle logs and output when it runs on cloud solution (but feasible also with the current container definition).

If it's safer we can try a two step delivery:

• I'll drop from this PR the two new docker images and just tag the existing one
• If some client asks for a docker as a command, we may reintroduce them

[cwgoes]

If you think two images is more convenient, I don't have a strong opinion.

[sabau]

In this moment I just need tagged docker images to spin off nodes on AWS, when we will need to scale we can decide if splitting or not to handle logs etc.

[cwgoes]

ACK although I haven't tested the images

[jackzampolin]

I don't think we need 2 images, but this work is great!