Merged
Conversation
alexanderbez
added
WIP
T: State Machine Breaking
alexanderbez
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #3763 +/- ##
==========================================
Coverage ? 61.35%
==========================================
Files ? 189
Lines ? 14098
Branches ? 0
==========================================
Hits ? 8650
Misses ? 4893
Partials ? 555 |
jackzampolin
approved these changes
Feb 28, 2019
Contributor
|
Way better errors here. |
alessio
reviewed
Mar 1, 2019
alessio
approved these changes
Mar 1, 2019
Contributor
alessio
left a comment
alessio
left a comment
There was a problem hiding this comment.
Just a small comment, looks good otherwise
cwgoes
reviewed
Mar 2, 2019
Contributor
cwgoes
left a comment
cwgoes
left a comment
There was a problem hiding this comment.
LGTM, thanks @alexanderbez
Contributor
|
Is this permanent? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable the use of ED25519 account key pairs as these result in completely untested code execution paths.
closes: #3751
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: