V0.33.1 zero export bugfix#3999
Merged
alexanderbez merged 3 commits intorelease/v0.33.1from Apr 2, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## release/v0.33.1 #3999 +/- ##
===================================================
- Coverage 60.89% 60.85% -0.04%
===================================================
Files 192 192
Lines 14288 14289 +1
===================================================
- Hits 8700 8696 -4
- Misses 5021 5026 +5
Partials 567 567 |
Contributor
|
Do we need a pendinglog entry here or a changelog entry here @alessio? |
Contributor
Author
|
We would want a changelog entry in the actual release |
Contributor
|
Pending entry is fine. Who handle the release will generate the new changelog I guess, don't they? @jackzampolin @alexanderbez |
alessio
reviewed
Mar 28, 2019
alessio
approved these changes
Mar 28, 2019
alessio
reviewed
Mar 30, 2019
| @@ -0,0 +1 @@ | |||
| #3656 distribution delegation zero export bugfix | |||
Contributor
There was a problem hiding this comment.
Hang on, 3656 is #3656. Is it correct to link the two?
alexanderbez
suggested changes
Apr 1, 2019
Contributor
alexanderbez
left a comment
There was a problem hiding this comment.
This is going directly into a hotfix release. I think therefor there should be no pending log entry, but rather a direct change log entry pointing to the PR #3999 instead of the original PR.
alexanderbez
approved these changes
Apr 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: