R4R [Staging PR 1/3]: module generalization#4208
Closed
rigelrozanski wants to merge 37 commits intomasterfrom
Closed
R4R [Staging PR 1/3]: module generalization#4208rigelrozanski wants to merge 37 commits intomasterfrom
rigelrozanski wants to merge 37 commits intomasterfrom
Conversation
rigelrozanski
requested review from
alessio,
alexanderbez and
jackzampolin
as code owners
rigelrozanski
changed the title
alexanderbez
suggested changes
Apr 27, 2019
Contributor
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
ACK -- left some minor comments 👍
alexanderbez
added
the
T: State Machine Breaking
Codecov Report
@@ Coverage Diff @@
## master #4208 +/- ##
==========================================
- Coverage 60.16% 59.41% -0.76%
==========================================
Files 212 220 +8
Lines 15188 15285 +97
==========================================
- Hits 9138 9081 -57
- Misses 5421 5577 +156
+ Partials 629 627 -2 |
Contributor
Author
|
closing in favour of #4159 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
develop PR was closed #4033
Most downstream PR
Upstream Staging #4128
closes #3006
REF affects #3976
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: