Conversation
Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
…mos-sdk into fedekunze/3972-supply
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
…mos-sdk into fedekunze/3972-supply
…mos-sdk into fedekunze/4082-supply-querier
aayushijain23
approved these changes
Jun 28, 2019
Contributor
aayushijain23
left a comment
aayushijain23
left a comment
There was a problem hiding this comment.
Looks good to me too.
colin-axner
approved these changes
Jun 28, 2019
Contributor
colin-axner
left a comment
colin-axner
left a comment
There was a problem hiding this comment.
LGTM, left a note for myself for updating supply REST endpoints
alessio
reviewed
Jun 29, 2019
alessio
suggested changes
Jun 29, 2019
Contributor
alessio
left a comment
alessio
left a comment
There was a problem hiding this comment.
Route paths should be snake_case - so they are elsewhere in the codebase.
Co-Authored-By: Alessio Treglia <quadrispro@ubuntu.com>
Contributor
|
Thanks @fedekunze - tests fail now |
alessio
approved these changes
Jul 1, 2019
alessio
dismissed
alexanderbez’s stale review
Suggestions have been incorporated. Hence dismissing in order to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4082
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: