resume simulations at a given height#4791
Merged
alexanderbez merged 5 commits intomasterfrom Aug 2, 2019
Merged
Conversation
fedekunze
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
fedekunze
commented
Jul 26, 2019
simapp/sim_test.go
Outdated
| func getSimulateFromSeedInput(tb testing.TB, w io.Writer, app *SimApp) ( | ||
| testing.TB, io.Writer, *baseapp.BaseApp, simulation.AppStateFn, int64, | ||
| simulation.WeightedOperations, sdk.Invariants, int, int, int, | ||
| simulation.WeightedOperations, sdk.Invariants, int, int, int, int, |
Contributor
Author
There was a problem hiding this comment.
sorry @alexanderbez. I promise I'll refactor this later lol
Codecov Report
@@ Coverage Diff @@
## master #4791 +/- ##
=======================================
Coverage 54.18% 54.18%
=======================================
Files 269 269
Lines 17191 17191
=======================================
Hits 9315 9315
Misses 7186 7186
Partials 690 690 |
alexanderbez
suggested changes
Jul 26, 2019
rigelrozanski
approved these changes
Jul 29, 2019
Contributor
rigelrozanski
left a comment
rigelrozanski
left a comment
There was a problem hiding this comment.
ACK - one suggestion
Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com>
…/cosmos/cosmos-sdk into fedekunze/4490-pause-resume-sims
alexanderbez
pushed a commit
that referenced
this pull request
Aug 8, 2019
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #4490
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [-t <tag>] [-m <msg>]Re-reviewed
Files changedin the github PR explorerFor Admin Use: