blacklist module accounts from receiving txs#4797
Merged
alexanderbez merged 12 commits intomasterfrom Jul 31, 2019
Merged
Conversation
fedekunze
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
alexanderbez
suggested changes
Jul 29, 2019
fedekunze
force-pushed
the
fedekunze/4795-fix-macc-inv
branch
from
115d91e to
adf6ddd
Compare
Codecov Report
@@ Coverage Diff @@
## master #4797 +/- ##
==========================================
+ Coverage 50.5% 50.54% +0.03%
==========================================
Files 288 288
Lines 18518 18596 +78
==========================================
+ Hits 9353 9399 +46
- Misses 8480 8506 +26
- Partials 685 691 +6 |
Codecov Report
@@ Coverage Diff @@
## master #4797 +/- ##
==========================================
+ Coverage 50.39% 50.59% +0.19%
==========================================
Files 288 288
Lines 18520 18546 +26
==========================================
+ Hits 9334 9384 +50
+ Misses 8501 8477 -24
Partials 685 685 |
…dekunze/4795-fix-macc-inv
alexanderbez
suggested changes
Jul 30, 2019
Contributor
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
One minor nit, but otherwise LGTM
colin-axner
reviewed
Jul 30, 2019
Co-Authored-By: colin axner <colinaxner@berkeley.edu>
alexanderbez
suggested changes
Jul 30, 2019
Contributor
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
Blocking on spec update and similar changes to distribution
golangcibot
reviewed
Jul 31, 2019
alexanderbez
pushed a commit
that referenced
this pull request
Jul 31, 2019
4 tasks
1 task
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4795
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [-t <tag>] [-m <msg>]Re-reviewed
Files changedin the github PR explorerFor Admin Use: