Merged
Conversation
Add infinite loop at the end of startStandAlone() to prevent the server process from exiting immediately after bootstrap. Closes: #4879
alessio
requested review from
alexanderbez,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4884 +/- ##
==========================================
- Coverage 54.05% 54.04% -0.02%
==========================================
Files 269 269
Lines 17116 17116
==========================================
- Hits 9252 9250 -2
- Misses 7178 7180 +2
Partials 686 686 |
tnachen
reviewed
Aug 12, 2019
| // run forever (the node will not be returned) | ||
| select {} | ||
|
|
||
| return nil |
Contributor
There was a problem hiding this comment.
I'm getting this error when I run make with this commit:
/Users/tnachen/go/bin/golangci-lint run
server/start.go:103:2: unreachable: unreachable code (govet)
return nil
Contributor
Author
There was a problem hiding this comment.
You're right, apparently for some reason this snippet dodged Golangci bot check: https://golangci.com/r/github.com/cosmos/cosmos-sdk/pulls/4884
alexanderbez
pushed a commit
that referenced
this pull request
Aug 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add infinite loop at the end of startStandAlone() to prevent
the server process from exiting immediately after bootstrap.
Closes: #4879
docs/)clog add [section] [-t <tag>] [-m <msg>]Files changedin the github PR explorerFor Admin Use: