Merged
Conversation
tnachen
requested review from
alessio,
alexanderbez,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4996 +/- ##
=========================================
- Coverage 55.51% 54.8% -0.71%
=========================================
Files 287 291 +4
Lines 17539 17840 +301
=========================================
+ Hits 9737 9778 +41
- Misses 7102 7358 +256
- Partials 700 704 +4 |
alexanderbez
suggested changes
Sep 5, 2019
Contributor
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
Thanks @tnachen, looks great! Left some feedback ☕️
tnachen
force-pushed
the
tim/4972-broadcast-errors
branch
from
a904f67 to
edd547b
Compare
alexanderbez
suggested changes
Sep 5, 2019
tnachen
force-pushed
the
tim/4972-broadcast-errors
branch
from
edd547b to
5b51d26
Compare
fedekunze
suggested changes
Sep 6, 2019
Contributor
fedekunze
left a comment
fedekunze
left a comment
There was a problem hiding this comment.
minor nit. Otherwise LGTM
tnachen
force-pushed
the
tim/4972-broadcast-errors
branch
from
5b51d26 to
6cc67aa
Compare
fedekunze
approved these changes
Sep 6, 2019
Contributor
fedekunze
left a comment
fedekunze
left a comment
There was a problem hiding this comment.
ACK. As a suggestion please try to not force-push so reviewers won't need to re-review the whole PR (just the new diffs from the latest comments).
jackzampolin
approved these changes
Sep 9, 2019
Contributor
jackzampolin
left a comment
jackzampolin
left a comment
There was a problem hiding this comment.
Nice UX improvement here @tnachen!
alexanderbez
suggested changes
Sep 10, 2019
tnachen
force-pushed
the
tim/4972-broadcast-errors
branch
from
96afedf to
d7c99bc
Compare
tnachen
force-pushed
the
tim/4972-broadcast-errors
branch
from
d7c99bc to
211fe23
Compare
Contributor
Author
|
@alexanderbez changed to use string matching now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #4972
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the github PR explorerFor Admin Use: