Skip to content

proto: migrate params to hybrid codec#5619

Merged
alexanderbez merged 34 commits intomasterfrom
proto/params
Feb 12, 2020
Merged

proto: migrate params to hybrid codec#5619
alexanderbez merged 34 commits intomasterfrom
proto/params

Conversation

@tac0turtle
Copy link
Copy Markdown
Contributor

work towards moving params to hybrid codec

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@tac0turtle tac0turtle added T: State Machine Breaking State machine breaking changes (impacts consensus). WIP C:x/params labels Feb 6, 2020
@tac0turtle tac0turtle changed the title proto: migrate params to hybridcodec proto: migrate params to hybrid codec Feb 6, 2020
@alexanderbez alexanderbez mentioned this pull request Feb 11, 2020
28 tasks
@alexanderbez alexanderbez marked this pull request as ready for review February 12, 2020 15:49
@alexanderbez alexanderbez added R4R and removed WIP labels Feb 12, 2020
Copy link
Copy Markdown
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 48d39e3 into master Feb 12, 2020
@alexanderbez alexanderbez deleted the proto/params branch February 12, 2020 16:34
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:x/params T: State Machine Breaking State machine breaking changes (impacts consensus).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants