Fix nil pointer deref in distribution tax/rewward validation helpers#5620
Merged
alexanderbez merged 7 commits intomasterfrom Feb 7, 2020
Merged
Fix nil pointer deref in distribution tax/rewward validation helpers#5620alexanderbez merged 7 commits intomasterfrom
alexanderbez merged 7 commits intomasterfrom
Conversation
dce0d0a to
a9e9af7
Compare
alexanderbez
reviewed
Feb 6, 2020
Contributor
alexanderbez
left a comment
There was a problem hiding this comment.
Can you allude to when an Int or Dec would be Nil? This should never be the case.
Contributor
|
Please reference the issue in the PR body @alessio |
alexanderbez
reviewed
Feb 6, 2020
jackzampolin
reviewed
Feb 6, 2020
Before checking Dec's value, one has to ensure the internal big.Int pointer is not nil first. Closes: #5621
bb967ad to
4d69262
Compare
Contributor
Author
|
@alexanderbez @jackzampolin please have another look |
golangcibot
reviewed
Feb 7, 2020
alexanderbez
suggested changes
Feb 7, 2020
Contributor
alexanderbez
left a comment
There was a problem hiding this comment.
@alessio please address the scope linting errors in the tests.
alexanderbez
reviewed
Feb 7, 2020
golangcibot
reviewed
Feb 7, 2020
golangcibot
reviewed
Feb 7, 2020
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #5620 +/- ##
==========================================
+ Coverage 44.63% 44.64% +<.01%
==========================================
Files 324 324
Lines 24707 24707
==========================================
+ Hits 11029 11031 +2
+ Misses 12618 12616 -2
Partials 1060 1060
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before checking Dec's value, one has to ensure the internal big.Int
pointer is not nil first.
Closes: #5621
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)