Skip to content

ADR 020 - Protocol Buffer Transaction Encoding#5757

Merged
alexanderbez merged 8 commits intomasterfrom
bez/adr-020-proto-client-encoding
Mar 9, 2020
Merged

ADR 020 - Protocol Buffer Transaction Encoding#5757
alexanderbez merged 8 commits intomasterfrom
bez/adr-020-proto-client-encoding

Conversation

@alexanderbez
Copy link
Copy Markdown
Contributor

@alexanderbez alexanderbez commented Mar 6, 2020

/cc @aaronc @jackzampolin @marbar3778


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added WIP T: ADR An issue or PR relating to an architectural decision record labels Mar 6, 2020
@alexanderbez alexanderbez marked this pull request as ready for review March 6, 2020 17:30
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 9, 2020

Codecov Report

Merging #5757 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5757   +/-   ##
=======================================
  Coverage   35.91%   35.91%           
=======================================
  Files         341      341           
  Lines       34745    34745           
=======================================
  Hits        12478    12478           
  Misses      21023    21023           
  Partials     1244     1244           

@alexanderbez alexanderbez changed the title ADR 020 - Protocol Buffer Client Encoding ADR 020 - Protocol Buffer Transaction Encoding Mar 9, 2020
@alexanderbez alexanderbez merged commit 9d49fe9 into master Mar 9, 2020
@alexanderbez alexanderbez deleted the bez/adr-020-proto-client-encoding branch March 9, 2020 17:15
@clevinson clevinson added this to the v0.39 milestone May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T: ADR An issue or PR relating to an architectural decision record

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants