Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5810 +/- ##
=========================================
- Coverage 32.51% 32.3% -0.21%
=========================================
Files 346 353 +7
Lines 39012 39461 +449
=========================================
+ Hits 12684 12749 +65
- Misses 25061 25439 +378
- Partials 1267 1273 +6
|
jgimeno
requested review from
alessio,
alexanderbez,
fedekunze,
hschoenburg and
nylira
as code owners
alessio
reviewed
Mar 16, 2020
4 tasks
alessio
suggested changes
Mar 16, 2020
Contributor
alessio
left a comment
alessio
left a comment
There was a problem hiding this comment.
Good start! I'd love some test cases - at least to avoid code coverage to get even lower. Plus, all query commands should all fail if --offline is passed
tac0turtle
changed the title
jgimeno
changed the title
alexanderbez
previously requested changes
Mar 18, 2020
Contributor
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
Looks great @jgimeno! Let's get a branch open against Gaia that tests this out.
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
alessio
reviewed
Mar 18, 2020
…m:cosmos/cosmos-sdk into jonathan/5448-split-generate-only-offline
11 tasks
Contributor
Author
|
Here is the branch using this changes cosmos/gaia#326 |
Contributor
|
FTR @jgimeno and I are testing the changes with |
Contributor
|
Please merge when thorough testing has been performed @alessio. |
…m:cosmos/cosmos-sdk into jonathan/5448-split-generate-only-offline
Contributor
|
Manual testing passed. We're now investigating into the drop of coverage stats. |
alessio
reviewed
Mar 18, 2020
alessio
reviewed
Mar 19, 2020
alessio
approved these changes
Mar 19, 2020
Contributor
alessio
left a comment
alessio
left a comment
There was a problem hiding this comment.
Just a minor thing left, otherwise this is good to go
alessio
dismissed
alexanderbez’s stale review
Dismissing review as per #5810 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #5448
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)