Skip to content

crypto/keys: move keybase and keyring to crypto/keyring/ dir#5866

Merged
mergify[bot] merged 12 commits intomasterfrom
fedekunze/5819-move-keys
Mar 25, 2020
Merged

crypto/keys: move keybase and keyring to crypto/keyring/ dir#5866
mergify[bot] merged 12 commits intomasterfrom
fedekunze/5819-move-keys

Conversation

@fedekunze
Copy link
Copy Markdown
Contributor

Description

re: #5819

Moves the keyring and keybase types to a keyring/ directory. Tendermint key types will follow in a later PR


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze added R4R C:Keys Keybase, KMS and HSMs Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Mar 24, 2020
Copy link
Copy Markdown
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! Even package names now make sense!

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2020

Codecov Report

Merging #5866 into master will decrease coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5866      +/-   ##
==========================================
- Coverage   32.32%   32.27%   -0.05%     
==========================================
  Files         353      355       +2     
  Lines       39476    39447      -29     
==========================================
- Hits        12760    12731      -29     
  Misses      25440    25440              
  Partials     1276     1276
Impacted Files Coverage Δ
crypto/keyring/info.go 80.24% <ø> (ø)
crypto/keyring/base_keybase.go 74% <ø> (ø)
crypto/keyring/lazy_keybase.go 57.26% <ø> (ø)
crypto/keyring/output.go 58.13% <ø> (ø)
types/errors/errors.go 71.79% <ø> (ø) ⬆️
client/keys/types.go 100% <ø> (ø) ⬆️
crypto/keyring/codec.go 100% <ø> (ø)
client/context/context.go 32.86% <0%> (ø) ⬆️
x/auth/client/cli/tx_multisign.go 0% <0%> (ø) ⬆️
x/auth/types/txbuilder.go 23.4% <0%> (ø) ⬆️
... and 18 more

@tac0turtle tac0turtle mentioned this pull request Mar 24, 2020
13 tasks
Copy link
Copy Markdown
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming no changes to business logic).

@alexanderbez
Copy link
Copy Markdown
Contributor

Please fix GolangCI and then feel free to merge 👍

@mergify mergify bot merged commit 9cce836 into master Mar 25, 2020
@alessio alessio deleted the fedekunze/5819-move-keys branch March 14, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:Keys Keybase, KMS and HSMs Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants