crypto/keys: move keybase and keyring to crypto/keyring/ dir#5866
Merged
mergify[bot] merged 12 commits intomasterfrom Mar 25, 2020
Merged
crypto/keys: move keybase and keyring to crypto/keyring/ dir#5866mergify[bot] merged 12 commits intomasterfrom
mergify[bot] merged 12 commits intomasterfrom
Conversation
golangcibot
reviewed
Mar 24, 2020
alessio
approved these changes
Mar 24, 2020
Contributor
alessio
left a comment
There was a problem hiding this comment.
Brilliant! Even package names now make sense!
fedekunze
commented
Mar 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #5866 +/- ##
==========================================
- Coverage 32.32% 32.27% -0.05%
==========================================
Files 353 355 +2
Lines 39476 39447 -29
==========================================
- Hits 12760 12731 -29
Misses 25440 25440
Partials 1276 1276
|
golangcibot
reviewed
Mar 24, 2020
…cosmos-sdk into fedekunze/5819-move-keys
golangcibot
reviewed
Mar 24, 2020
golangcibot
reviewed
Mar 24, 2020
golangcibot
reviewed
Mar 24, 2020
alexanderbez
approved these changes
Mar 25, 2020
Contributor
alexanderbez
left a comment
There was a problem hiding this comment.
LGTM (assuming no changes to business logic).
Contributor
|
Please fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
re: #5819
Moves the keyring and keybase types to a
keyring/directory. Tendermint key types will follow in a later PRFor contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)