Tx Client Migration: x/staking#5915
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5915 +/- ##
==========================================
- Coverage 57.06% 56.48% -0.58%
==========================================
Files 342 342
Lines 20056 20261 +205
==========================================
Hits 11444 11444
- Misses 7767 7972 +205
Partials 845 845
|
sahith-narahari
requested review from
alessio,
alexanderbez,
fedekunze,
hschoenburg and
nylira
as code owners
x/staking/client/cli/tx.go
Outdated
| defaultMinSelfDelegation = "1" | ||
| ) | ||
|
|
||
| // NewTxCmd returns a root CLI command handler for all x/slashing transaction commands. |
There was a problem hiding this comment.
| // NewTxCmd returns a root CLI command handler for all x/slashing transaction commands. | |
| // NewTxCmd returns a root CLI command handler for all x/staking transaction commands. |
|
@alexanderbez did we decide we are or aren't migrating the tx REST handlers now? My sense based on our discussion around gRPC is that we were going to hold off on that now and think of a more holistic approach that includes that. Is that right? |
|
Actually thinking about this more, I don't see how we can introduce gRPC and keep the legacy REST server around. That would only work if we keep all the legacy types and querier logic -- which we aren't. Correct me if I'm wrong here. To answer your question, yes, this PR should have a migration for the TX REST handler, which you've done, thanks! |
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
LGTM -- great work @sahith-narahari 👍
@alexanderbez Yes, we need to leave the old querier logic around, but I don't really see that as a problem - it can reuse the proto-generated types for parameters. We can see what it looks like in #5882 when I mark that R4R. |
|
We will need to evaluate most likely via actual implementation and usage. It's hard to visualize it right now. |
| WithAccountRetriever(ar) | ||
|
|
||
| txBldr, msg, err := BuildCreateValidatorMsg(cliCtx, txBldr) | ||
| cliCtx := context.NewCLIContextWithInputAndFrom(inBuf, args[0]).WithMarshaler(m) |
| WithTxGenerator(txg). | ||
| WithAccountRetriever(ar) | ||
|
|
||
| cliCtx := context.NewCLIContextWithInputAndFrom(inBuf, args[0]).WithMarshaler(m) |
| WithTxGenerator(txg). | ||
| WithAccountRetriever(ar) | ||
|
|
||
| cliCtx := context.NewCLIContextWithInputAndFrom(inBuf, args[0]).WithMarshaler(m) |
| WithTxGenerator(txg). | ||
| WithAccountRetriever(ar) | ||
|
|
||
| cliCtx := context.NewCLIContextWithInputAndFrom(inBuf, args[0]).WithMarshaler(m) |
| WithTxGenerator(txg). | ||
| WithAccountRetriever(ar) | ||
|
|
||
| cliCtx := context.NewCLIContextWithInputAndFrom(inBuf, args[0]).WithMarshaler(m) |
5 participants
References: #5864
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)