Merged
Conversation
alexanderbez
requested review from
alessio,
fedekunze,
hschoenburg and
nylira
as code owners
15 tasks
fedekunze
approved these changes
Apr 2, 2020
| return txCmd | ||
| } | ||
|
|
||
| // command to replace a delegator's withdrawal address |
Contributor
Author
There was a problem hiding this comment.
Must've been missed in the original PR. I'll remove 👍
aaronc
approved these changes
Apr 2, 2020
aaronc
reviewed
Apr 8, 2020
| inBuf := bufio.NewReader(cmd.InOrStdin()) | ||
| txBldr := auth.NewTxBuilderFromCLI(inBuf).WithTxEncoder(authclient.GetTxEncoder(cdc)) | ||
| cliCtx := context.NewCLIContextWithInput(inBuf).WithCodec(cdc) | ||
| cliCtx := context.NewCLIContextWithInputAndFrom(inBuf, args[0]).WithMarshaler(m) |
Member
There was a problem hiding this comment.
Should be NewCLIContextWithInput because args[0] is a module-name not an address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #5864
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)