Add consensus params into Simulation

[jgimeno]

Closes: #5988

Description

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #6002 into master will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6002      +/-   ##
==========================================
- Coverage   54.71%   54.65%   -0.06%     
==========================================
  Files         424      424              
  Lines       25794    25820      +26     
==========================================
  Hits        14113    14113              
- Misses      10710    10736      +26     
  Partials      971      971              

[alexanderbez]

Thanks @jgimeno, I left a few bits of feedback.

[alexanderbez]

Is this even called/used? I'd opt to remove it.

[jgimeno]

yeah in x/simulation/params.go line 182

[alexanderbez]

Ok so you removed the other, now removed private helper function 👍

[alexanderbez]

LGTM 🎉

[alexanderbez]

Ok so you removed the other, now removed private helper function 👍

[fedekunze]

test-sim-import-export failed

[jgimeno]

Checking

[fedekunze]

so the problem is that newApp calls mm.InitGenesis which doesn't populate the consensus params:

        // TestAppImportExport L86
	appState, _, cp, err := app.ExportAppStateAndValidators(false, []string{}) // return ConsensusParams
	require.NoError(t, err)
	require.NotNil(t, cp)

	fmt.Printf("importing genesis...\n")

	_, newDB, newDir, _, _, err := SetupSimulation("leveldb-app-sim-2", "Simulation-2")
	require.NoError(t, err, "simulation setup failed")

	defer func() {
		newDB.Close()
		require.NoError(t, os.RemoveAll(newDir))
	}()

	newApp := NewSimApp(log.NewNopLogger(), newDB, nil, true, map[int64]bool{}, DefaultNodeHome, FlagPeriodValue, fauxMerkleModeOpt)
	require.Equal(t, "SimApp", newApp.Name())

	var genesisState GenesisState
	err = app.Codec().UnmarshalJSON(appState, &genesisState)
	require.NoError(t, err)
	genesisState["consensus_params"] = app.Codec().MustMarshalJSON(cp) // add consensus params

	ctxA := app.NewContext(true, abci.Header{Height: app.LastBlockHeight()})
	ctxB := newApp.NewContext(true, abci.Header{Height: app.LastBlockHeight()})
	newApp.mm.InitGenesis(ctxB, app.Codec(), genesisState) // will fail because consensus params are not part of any module

[jgimeno]

Ok thanks! Got it, can we revert this branch meanwhile?