Update DefaultHistoricalEntries to 100#6059
Conversation
jackzampolin
requested review from
alessio,
alexanderbez,
fedekunze,
hschoenburg and
nylira
as code owners
x/staking/types/params.go
Outdated
| // DefaultHistorical entries is 0 since it must only be non-zero for | ||
| // IBC connected chains | ||
| DefaultHistoricalEntries uint32 = 0 | ||
| DefaultHistoricalEntries uint32 = 1000 |
There was a problem hiding this comment.
Any rationale behind this value?
There was a problem hiding this comment.
This will govern how low-latency IBC handshakes must be in order to complete in time. I think 1000 is fine, it's probably even fine to use something much lower, like 100.
There was a problem hiding this comment.
I see. Are historical entries persisted in state? If so, we should opt for a lower bound instead (nitpick).
There was a problem hiding this comment.
after block 100 the new ones start overriding the old ones so there are always at most 100
fedekunze
left a comment
fedekunze
left a comment
There was a problem hiding this comment.
ACK. Pending @cwgoes and @AdityaSripal's approval
Codecov Report
@@ Coverage Diff @@
## master #6059 +/- ##
=======================================
Coverage 54.64% 54.64%
=======================================
Files 426 426
Lines 25890 25890
=======================================
Hits 14148 14148
Misses 10763 10763
Partials 979 979 |
cwgoes
left a comment
cwgoes
left a comment
There was a problem hiding this comment.
ACK, although I think we don't even need to keep 1000, at least as a default
x/staking/types/params.go
Outdated
| // DefaultHistorical entries is 0 since it must only be non-zero for | ||
| // IBC connected chains | ||
| DefaultHistoricalEntries uint32 = 0 | ||
| DefaultHistoricalEntries uint32 = 1000 |
There was a problem hiding this comment.
This will govern how low-latency IBC handshakes must be in order to complete in time. I think 1000 is fine, it's probably even fine to use something much lower, like 100.
fedekunze
changed the title
* Update DefaultHistoricalEntries to 1000 * hist entries sims and comment on simapp * changelog and godoc * update sim param change * update default to 100 Co-authored-by: Federico Kunze <federico.kunze94@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
4 participants
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)