Skip to content

Update ADR 020 to use Any#6111

Merged
aaronc merged 17 commits intomasterfrom
aaronc/6030-update-adr-020
May 13, 2020
Merged

Update ADR 020 to use Any#6111
aaronc merged 17 commits intomasterfrom
aaronc/6030-update-adr-020

Conversation

@aaronc
Copy link
Copy Markdown
Member

@aaronc aaronc commented May 1, 2020

ref: #6030, #6078


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@aaronc aaronc added the T: ADR An issue or PR relating to an architectural decision record label May 1, 2020
@aaronc aaronc marked this pull request as ready for review May 1, 2020 19:56
@aaronc aaronc added the R4R label May 1, 2020
@aaronc aaronc mentioned this pull request May 1, 2020
4 tasks
@clevinson clevinson added this to the v0.39 milestone May 1, 2020
Copy link
Copy Markdown
Contributor

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suff! Makes sense overall. Glad we got the requirements straight and can be more specific now.

Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
@aaronc aaronc requested a review from clevinson as a code owner May 4, 2020 19:01
Copy link
Copy Markdown
Contributor

@clevinson clevinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High level makes sense to me. Provided some small type-o suggestions, but nothing blocking.

@aaronc aaronc requested a review from jgimeno as a code owner May 13, 2020 15:55
Copy link
Copy Markdown
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aaronc aaronc mentioned this pull request May 13, 2020
27 tasks
aaronc added a commit that referenced this pull request May 13, 2020
@aaronc aaronc requested a review from clevinson May 13, 2020 18:46
Copy link
Copy Markdown
Contributor

@clevinson clevinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@aaronc aaronc merged commit 32f82a9 into master May 13, 2020
@aaronc aaronc deleted the aaronc/6030-update-adr-020 branch May 13, 2020 19:33
@aaronc aaronc mentioned this pull request May 19, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T: ADR An issue or PR relating to an architectural decision record

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants