Conversation
webmaster128
reviewed
May 2, 2020
Contributor
webmaster128
left a comment
There was a problem hiding this comment.
Great suff! Makes sense overall. Glad we got the requirements straight and can be more specific now.
alexanderbez
reviewed
May 4, 2020
alexanderbez
reviewed
May 4, 2020
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
alexanderbez
reviewed
May 4, 2020
alexanderbez
reviewed
May 4, 2020
clevinson
reviewed
May 6, 2020
Contributor
clevinson
left a comment
There was a problem hiding this comment.
High level makes sense to me. Provided some small type-o suggestions, but nothing blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #6030, #6078
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)