Merged
Conversation
fedekunze
requested review from
aaronc,
alessio,
alexanderbez,
clevinson and
jgimeno
as code owners
fedekunze
added
Type: Code Hygiene
fedekunze
commented
Jul 8, 2020
| } | ||
|
|
||
| // GetCmdQueryPath defines the command to query the commitment path. | ||
| func GetCmdQueryPath(clientCtx client.Context) *cobra.Command { |
Contributor
Author
There was a problem hiding this comment.
this query is not required anymore
fedekunze
requested review from
AdityaSripal,
amaury1093,
anilcse,
atheeshp,
blushi and
sahith-narahari
Codecov Report
@@ Coverage Diff @@
## master #6639 +/- ##
=======================================
Coverage 57.73% 57.73%
=======================================
Files 497 497
Lines 29767 29767
=======================================
Hits 17186 17186
Misses 11343 11343
Partials 1238 1238 |
9 tasks
amaury1093
reviewed
Jul 8, 2020
Contributor
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
lgtm overall, we could also refactor GetQueryCmd in this PR too?
| @@ -55,18 +54,16 @@ $ %s query ibc client states | |||
| // a given id as defined in https://github.com/cosmos/ics/tree/master/spec/ics-002-client-semantics#query | |||
| func GetCmdQueryClientState(clientCtx client.Context) *cobra.Command { | |||
Contributor
There was a problem hiding this comment.
Could remove client.Context arg from GetCmd* as part of this refactor too
Contributor
Author
There was a problem hiding this comment.
you need to pass in the clientCtx afaik. cc: @alexanderbez
Contributor
There was a problem hiding this comment.
Actually @fedekunze we need to remove it. A client.Context should never be passed as an arg -- query or tx. I'm not sure how I missed this in x/bank. Thanks for catching this @amaurymartiny!
x/bank PR: #6645
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ref: #6423
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes