Migrate x/genutil to use TxConfig#6734
Merged
mergify[bot] merged 44 commits intomasterfrom Jul 25, 2020
Merged
Conversation
This was referenced Jul 15, 2020
Closed
Codecov Report
@@ Coverage Diff @@
## master #6734 +/- ##
==========================================
+ Coverage 60.22% 61.55% +1.33%
==========================================
Files 389 509 +120
Lines 25361 31525 +6164
==========================================
+ Hits 15274 19406 +4132
- Misses 8919 10610 +1691
- Partials 1168 1509 +341 |
amaury1093
reviewed
Jul 20, 2020
Contributor
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
lgtm, but I have a question why we're passing explicitly txJSONDecoder and txBinaryEncoder (and not just txGenerator)
Member
I explained this to @blushi. The reason why is that we may get amino json and need to convert to protobuf binary. TxConfig isn't really intended to be used for the purpose. |
…rie/5917-x-genutil
…ronc/6734-updates
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
…os-sdk into aaronc/6734-updates
aaronc
requested changes
Jul 24, 2020
Member
aaronc
left a comment
aaronc
left a comment
There was a problem hiding this comment.
Mostly LGTM. Caught one piece that isn't migrated.
anilcse
reviewed
Jul 24, 2020
aaronc
changed the title
…rie/5917-x-genutil
aaronc
approved these changes
Jul 25, 2020
fedekunze
approved these changes
Jul 25, 2020
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* Update genutil collect and gentx to use TxGenerator * Remove print statement * Use Tx in genutil DeliverGenTxs * Use Tx in genutil genesis_state * Use Tx in ValidateGenesis * Use amino txJSONDecoder and txBinaryEncoder in genutil InitGenesis * Use TxConfig in place of TxGenerator * Add gentx tests * Remove commented line * Test fixes * Apply suggestions from code review Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> * Fixes * Fixes * Fixes * Fixes * Remove unneeded test case (doesn't apply to proto marshaling) * linting * Refactor to use new TxEncodingConfig interface in genutil module * Replace golang/protobuf with gogo/protobuf package * Use TxEncodingConfig in InitTestnet * Remove old amino.go file * Use TxJSONDecoder in genutil ValidateGenesis * Add parameter to ValidateGenesis to resolve the tx JSON decoder issue * Address review feedback Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com> Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com> Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ref: #6213 , #5917
x/genutil/client/clicovered as part of #6717Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes