Refactor x/auth/vesting to use ADR-031 by clevinson · Pull Request #7551 · cosmos/cosmos-sdk

clevinson · 2020-10-15T01:28:07Z

Description

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

blushi · 2020-10-15T14:41:26Z

@clevinson FYI x/ibc/light-clients/07-tendermint/types/tendermint.pb.go was broken because of #7562. This got fixed so you just need to merge master into your branch and re-run make proto-gen.

…roto-msg-services

codecov · 2020-10-15T18:15:07Z

Codecov Report

Merging #7551 into master will increase coverage by 3.72%.
The diff coverage is 74.46%.

@@            Coverage Diff             @@
##           master    #7551      +/-   ##
==========================================
+ Coverage   50.43%   54.15%   +3.72%     
==========================================
  Files         445      606     +161     
  Lines       28112    38168   +10056     
==========================================
+ Hits        14179    20671    +6492     
- Misses      12492    15401    +2909     
- Partials     1441     2096     +655

blushi

The code related to ADR 031 migration looks good to me, though golangci-lint error needs to be fixed.
Also why do we have all those tmp-swagger-gen/ files? I'd say you need to run make clean.

x/auth/vesting/msg_server.go

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>

…mos/cosmos-sdk into clevinson/vesting-proto-msg-services

aaronc

utACK

* update auth/vesting module to use proto msg services * rm accidental tmp files * Update x/auth/vesting/msg_server.go Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * golangci-lint fix Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Refactor RegisterQueryServices -> RegisterServices (#7518) * Refactor RegisterQueryServices -> RegisterServices * Fix tests * Add ADR 031 BaseApp and codec infrastructure (#7519) * Refactor RegisterQueryServices -> RegisterServices * Cleaner proto files * Fix tests * Add MsgServer * Fix lint * Remove MsgServer from configurator for now * Remove useless file * Fix build * typo * Add router * Fix test * WIP * Add router * Remove test helper * Add beginning of test * Move test to simapp? * ServiceMsg implement sdk.Msg * Add handler by MsgServiceRouter * Correct signature * Add full test * use TxEncoder * Update baseapp/msg_service_router.go Co-authored-by: Aaron Craelius <aaron@regen.network> * Push changes * WIP on ServiceMsg unpacking * Make TestMsgService test pass * Fix tests * Tidying up * Tidying up * Tidying up * Add JSON test * Add comments * Tidying * Lint * Register MsgRequest interface * Rename * Fix tests * RegisterCustomTypeURL * Add changelog entries * Put in features * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Address review comments * Address nit * Fix lint * Update codec/types/interface_registry.go Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * godoc Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com> Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * Refactor x/bank according to ADR 031 (#7520) * Refactor x/bank according to ADR 031 * Add comment * Update comment * Add comment * Add tests, address edge cases * Imports Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Refactor x/{gov, crisis} according to ADR 031 (#7533) * Refactor x/gov according to ADR 31 * fix tests * Refactor x/crisis according to ADR 031 * fix lint * lint * lint * review changes * lint * review change * fic doc Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Refactor x/distribution according to ADR 031 (#7524) * Refactor x/distribution according to ADR 31 * lint * removed unused * Apply suggestions from code review Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * [x/slashing] Implement Protobuf Msg Services (#7557) * Update x/slashing to use proto msg service * Fix proto-gen Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Refactor x/auth/vesting to use ADR-031 (#7551) * update auth/vesting module to use proto msg services * rm accidental tmp files * Update x/auth/vesting/msg_server.go Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * golangci-lint fix Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Refactor x/staking according to ADR 031 (#7556) * Refactor x/staking according to ADR 031 * lint * review changes * review changes * review changes Co-authored-by: Aaron Craelius <aaron@regen.network> * Add MsgServer to Configurator for ADR 031 wiring (#7584) * Add MsgServer to Configurator for ADR 031 wiring * Add docs, wire up evidence & staking * Add integration test * Add comments * Doc strings * Update types/module/configurator.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update types/module/configurator.go Co-authored-by: Cory <cjlevinson@gmail.com> * Wire up vesting * Update CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com> Co-authored-by: Cory <cjlevinson@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Refactor x/evidence to ADR-031 (#7538) * Refactor x/evidence to ADR-031 * Add hash in response * Update changelog * Update x/evidence/keeper/keeper.go * Update proto/cosmos/evidence/v1beta1/tx.proto Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * Use msgServer struct Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * Refactor x/ibc to ADR 031 (#7576) * WIP: Refactor x/ibc to ADR 031 * updated handler * removed unsued * fix * Add proto service for ibc/transfer * lint * remove old upgrade handler * added doc * review changes * fix tests * formatter * Add MsgServer wiring in RegisterServices Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * add changelog entries for non-nil Result.Data fields in message responses Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com> Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>

update auth/vesting module to use proto msg services

21964c0

clevinson mentioned this pull request Oct 15, 2020

Implement ADR 031: Protobuf Msg Services #7500

Closed

16 tasks

clevinson linked an issue Oct 15, 2020 that may be closed by this pull request

[x/vesting] Implement Protobuf Msg Services #7548

Closed

Merge remote-tracking branch 'origin/master' into clevinson/vesting-p…

35ca648

…roto-msg-services

clevinson marked this pull request as ready for review October 15, 2020 18:09

clevinson requested review from aaronc, alessio and alexanderbez as code owners October 15, 2020 18:09

clevinson requested a review from blushi October 15, 2020 18:09

blushi suggested changes Oct 16, 2020

View reviewed changes

x/auth/vesting/msg_server.go Outdated Show resolved Hide resolved

clevinson and others added 4 commits October 16, 2020 12:14

rm accidental tmp files

a9e1134

Update x/auth/vesting/msg_server.go

4c005f6

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>

golangci-lint fix

5cf3091

Merge branch 'clevinson/vesting-proto-msg-services' of github.com:cos…

838bfa1

…mos/cosmos-sdk into clevinson/vesting-proto-msg-services

aaronc approved these changes Oct 16, 2020

View reviewed changes

Merge branch 'master' into clevinson/vesting-proto-msg-services

e3109b0

aaronc added the automerge label Oct 16, 2020

aaronc requested review from amaury1093, anilcse, atheeshp, blushi and robert-zaremba October 16, 2020 19:55

blushi approved these changes Oct 19, 2020

View reviewed changes

mergify bot added 2 commits October 19, 2020 08:50

Merge branch 'master' into clevinson/vesting-proto-msg-services

64b86c3

Merge branch 'master' into clevinson/vesting-proto-msg-services

393260e

mergify bot merged commit 8138605 into master Oct 19, 2020

mergify bot deleted the clevinson/vesting-proto-msg-services branch October 19, 2020 09:22

clevinson mentioned this pull request Oct 19, 2020

Implement Protobuf Msg Services #7540

Closed

16 tasks

clevinson mentioned this pull request Oct 19, 2020

[backport/v0.40.x] Implement ADR031 #7599

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor x/auth/vesting to use ADR-031#7551

Refactor x/auth/vesting to use ADR-031#7551
mergify[bot] merged 9 commits intomasterfrom
clevinson/vesting-proto-msg-services

clevinson commented Oct 15, 2020 •

edited by aaronc

Loading

Uh oh!

blushi commented Oct 15, 2020

Uh oh!

codecov bot commented Oct 15, 2020 •

edited

Loading

Uh oh!

blushi left a comment

Uh oh!

Uh oh!

aaronc left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

clevinson commented Oct 15, 2020 • edited by aaronc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

blushi commented Oct 15, 2020

Uh oh!

codecov bot commented Oct 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blushi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aaronc left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

clevinson commented Oct 15, 2020 •

edited by aaronc

Loading

codecov bot commented Oct 15, 2020 •

edited

Loading