Merged
Conversation
robert-zaremba
requested review from
aaronc,
alessio and
alexanderbez
as code owners
robert-zaremba
requested review from
amaury1093,
anilcse,
blushi and
cyberbono3
Contributor
Author
|
Guys, what do you think about this? |
Contributor
|
It does not do any harm 👍 |
cyberbono3
reviewed
Mar 10, 2021
Contributor
cyberbono3
left a comment
cyberbono3
left a comment
There was a problem hiding this comment.
Yeah, it just extends basic error with more details.
aaronc
approved these changes
Mar 11, 2021
alessio
approved these changes
Mar 12, 2021
|
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=ad47ccf8477e4ae79fbbf684036a463a |
|
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=282a0f0b26ac2fe6f5a42918839602cfce0d6725 |
Codecov Report
@@ Coverage Diff @@
## master #8845 +/- ##
==========================================
- Coverage 59.17% 59.16% -0.01%
==========================================
Files 571 571
Lines 31800 31802 +2
==========================================
Hits 18817 18817
- Misses 10780 10782 +2
Partials 2203 2203
|
Contributor
Author
|
Github CI has problems today - I think I'm rerunning this tests already 4 times. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.