Skip to content

fix: nil pointer panic on NewIntFromBigInt#9627

Merged
alexanderbez merged 3 commits intomasterfrom
fedekunze/big-int-panic
Jul 5, 2021
Merged

fix: nil pointer panic on NewIntFromBigInt#9627
alexanderbez merged 3 commits intomasterfrom
fedekunze/big-int-panic

Conversation

@fedekunze
Copy link
Copy Markdown
Contributor

@fedekunze fedekunze commented Jul 3, 2021 •
edited
Loading

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@fedekunze fedekunze changed the title fix: nil pointer panic on NewIntFromBigInt fix: nil pointer panic on NewIntFromBigInt Jul 3, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 3, 2021 •
edited
Loading

Codecov Report

Merging #9627 (8736396) into master (57d523d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9627   +/-   ##
=======================================
  Coverage   60.54%   60.55%           
=======================================
  Files         588      588           
  Lines       37447    37449    +2     
=======================================
+ Hits        22674    22676    +2     
  Misses      12781    12781           
  Partials     1992     1992
Impacted Files Coverage Δ
types/int.go 73.28% <100.00%> (+0.37%) ⬆️

@fedekunze fedekunze requested review from amaury1093 and clevinson July 5, 2021 05:55
@amaury1093
Copy link
Copy Markdown
Contributor

amaury1093 commented Jul 5, 2021

We dropped support for Launchpad, I propose to remove that backport

@alexanderbez alexanderbez merged commit 7f90374 into master Jul 5, 2021
@alexanderbez alexanderbez deleted the fedekunze/big-int-panic branch July 5, 2021 12:36
mergify bot pushed a commit that referenced this pull request Jul 5, 2021
@fedekunze
types: fix nil pointer panic on NewIntFromBigInt (#9627)
f425eb0 
(cherry picked from commit 7f90374)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Jul 5, 2021
Closed
mergify bot pushed a commit that referenced this pull request Jul 5, 2021
@fedekunze
types: fix nil pointer panic on NewIntFromBigInt (#9627)
b6614f5 
(cherry picked from commit 7f90374)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Jul 5, 2021
Closed
@fedekunze fedekunze mentioned this pull request Dec 28, 2021
Closed
12 tasks
@tac0turtle
Copy link
Copy Markdown
Contributor

tac0turtle commented Dec 28, 2021

@Mergifyio backport release/v0.45.x

@mergify mergify bot mentioned this pull request Dec 28, 2021
Merged
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 28, 2021

backport release/v0.45.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Dec 28, 2021
@fedekunze
types: fix nil pointer panic on NewIntFromBigInt (#9627)
bb46297 
(cherry picked from commit 7f90374)

# Conflicts:
#	CHANGELOG.md
tac0turtle pushed a commit that referenced this pull request Dec 29, 2021
@mergify @fedekunze @alexanderbez
fix: nil pointer panic on NewIntFromBigInt (backport #9627) (#10845)
f67928a 
* types: fix nil pointer panic on `NewIntFromBigInt` (#9627)

(cherry picked from commit 7f90374)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
@faddat faddat mentioned this pull request Feb 28, 2022
Closed
8 tasks
zakir-web3 pushed a commit to PundiAI/cosmos-sdk that referenced this pull request Apr 8, 2022
@mergify @fedekunze @alexanderbez
fix: nil pointer panic on NewIntFromBigInt (backport cosmos#9627) (c…
e9e7997 
…osmos#10845)

* types: fix nil pointer panic on `NewIntFromBigInt` (cosmos#9627)

(cherry picked from commit 7f90374)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
JimLarson pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Jul 7, 2022
@mergify @fedekunze
@alexanderbez @JimLarson
fix: nil pointer panic on NewIntFromBigInt (backport cosmos#9627) (c…
09174ce 
…osmos#10845)

* types: fix nil pointer panic on `NewIntFromBigInt` (cosmos#9627)

(cherry picked from commit 7f90374)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@mergify @fedekunze
@alexanderbez @JeancarloBarrios
fix: nil pointer panic on NewIntFromBigInt (backport cosmos#9627) (c…
774a88c 
…osmos#10845)

* types: fix nil pointer panic on `NewIntFromBigInt` (cosmos#9627)

(cherry picked from commit 7f90374)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronc aaronc Awaiting requested review from aaronc

@clevinson clevinson Awaiting requested review from clevinson

2 more reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fedekunze @amaury1093 @tac0turtle @alexanderbez