feat: support address codec in erc20 callbacks#569
Closed
yihuang wants to merge 12 commits intocosmos:mainfrom
Closed
feat: support address codec in erc20 callbacks#569yihuang wants to merge 12 commits intocosmos:mainfrom
yihuang wants to merge 12 commits intocosmos:mainfrom
Conversation
Solution: - change address conversion in middleware
mmsqe
reviewed
Aug 29, 2025
aljo242
changed the title
Contributor
|
@yihuang needs a changelog and to note that it is API breaking |
mmsqe
reviewed
Sep 3, 2025
| // check if minting to a recipient address other than the sender is enabled | ||
| // for for the given coin denom | ||
| if !sender.Equals(receiver) && !k.bankKeeper.IsSendEnabledCoin(ctx, coin) { | ||
| if strSender != strReceiver && !k.bankKeeper.IsSendEnabledCoin(ctx, coin) { |
Collaborator
There was a problem hiding this comment.
sender is eth address while receiver is still cosmos address right?
Contributor
|
@yihuang lint and tests failing |
Contributor
|
Can we add a test that validates this new behavior? |
Collaborator
Author
I converted it to draft, because I'm getting confused at what exactly what we should do here. On the other hand, the UI can also do the address format conversions. |
vladjdk
changed the title
Collaborator
Author
|
fixed by #701 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #570
see: cosmos/ibc-go#8573
Solution:
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch