fix(v2): prevent stale channel messages in MultiTree concurrency#1140
Open
songgaoye wants to merge 4 commits intocosmos:masterfrom
Open
fix(v2): prevent stale channel messages in MultiTree concurrency#1140songgaoye wants to merge 4 commits intocosmos:masterfrom
songgaoye wants to merge 4 commits intocosmos:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SaveVersionConcurrently,SnapshotConcurrently, andWarmLeavespreviouslyused shared
errorCh/doneChchannels. Surplus messages could remain in thebuffers and be consumed by later calls, causing version mismatches or
incorrect results.
Use per-call local result channels (one message per goroutine) to avoid
cross-call contamination. Remove the unused
doneCh/errorChfields andsaveVersionResulttype, and haveWarmLeavescollect all errors.Add tests covering: single-tree error, all-trees error,
sequential
calls after recovery, SnapshotConcurrently error,
WarmLeaves error
collection, and happy path. Use tableSchema() to
reconstruct dropped
tables from sqlite_master rather than hardcoding column
definitions.