-
Notifications
You must be signed in to change notification settings - Fork 751
Closed
Labels
03-connectiongood first issueGood for newcomersGood for newcomerstype: code hygieneClean up code but without changing functionality or interfacesClean up code but without changing functionality or interfaces
Description
Pre-requirements:
Summary
Remove the Version interface.
Problem Definition
The Version interface was added to fulfill the GetVersions interface. As this function will be removed, this abstraction is no longer necessary and will prevent us from doing unnecessary type casting between the interface and the concrete implementation.
Proposal
- Remove the Version interface
- Remove functions casting between the two types
- Replace all API's with the concrete version type. That is use
*Versioninstead ofexported.Versionwithin theversion.gofile - Add changelog entry
There might be some unforseen issue I am overlooking. Please comment if you run into an issue. This change is primarily a code improvement and thus a nice to have
For Admin Use
- Not duplicate issue
- Appropriate labels applied
- Appropriate contributors tagged/assigned
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
03-connectiongood first issueGood for newcomersGood for newcomerstype: code hygieneClean up code but without changing functionality or interfacesClean up code but without changing functionality or interfaces