feat: Add GetAppVersion to ICS4Wrapper#1022
Merged
colin-axner merged 18 commits intomainfrom Apr 20, 2022
Merged
Conversation
Add a function to 04-channel keeper which can be used in the ICS4Wrapper interface for obtaining the unwrapped channel verison
colin-axner
requested review from
AdityaSripal,
charleenfei,
crodriguezvega,
damiannolan,
fedekunze and
seantking
as code owners
colin-axner
commented
Feb 28, 2022
colin-axner
commented
Feb 28, 2022
colin-axner
commented
Feb 28, 2022
Contributor
Author
|
I actually don't think I need this for #821 any longer, but it still seems useful |
damiannolan
approved these changes
Mar 1, 2022
AdityaSripal
reviewed
Mar 2, 2022
Contributor
Author
|
Naming still needs to be decided. At the very least I think I can rename to Ideally we have something that conveys the version returned should be the version this layer of the stack was given |
colin-axner
changed the title
seantking
reviewed
Apr 14, 2022
seantking
reviewed
Apr 14, 2022
seantking
reviewed
Apr 14, 2022
seantking
reviewed
Apr 14, 2022
seantking
approved these changes
Apr 14, 2022
Contributor
seantking
left a comment
seantking
left a comment
There was a problem hiding this comment.
LGTM :-) Left a few mega nits
Co-authored-by: Sean King <seantking@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
=======================================
Coverage 80.30% 80.31%
=======================================
Files 166 166
Lines 11980 12004 +24
=======================================
+ Hits 9621 9641 +20
- Misses 1905 1908 +3
- Partials 454 455 +1
🚀 New features to boost your workflow:
|
damiannolan
approved these changes
Apr 14, 2022
Contributor
damiannolan
left a comment
damiannolan
left a comment
There was a problem hiding this comment.
ack latest! super clean, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #1002
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes