chore: adding UpdateState to ClientState interface#1206
Merged
damiannolan merged 7 commits into02-client-refactorfrom Mar 31, 2022
Merged
chore: adding UpdateState to ClientState interface#1206damiannolan merged 7 commits into02-client-refactorfrom
damiannolan merged 7 commits into02-client-refactorfrom
Conversation
damiannolan
requested review from
AdityaSripal,
colin-axner and
fedekunze
as code owners
damiannolan
commented
Mar 30, 2022
modules/core/exported/client.go
Outdated
Comment on lines
+62
to
+64
| // UpdateState updates and stores the ClientState and associated ConsensusState using the provided KVStore and ClientMessage Header | ||
| // An error is returned if ClientMessage is of type Misbehaviour | ||
| UpdateState(sdk.Context, codec.BinaryCodec, sdk.KVStore, ClientMessage) error |
Contributor
Author
There was a problem hiding this comment.
Open to suggestions for improving the godoc here :)
colin-axner
approved these changes
Mar 31, 2022
Contributor
colin-axner
left a comment
colin-axner
left a comment
There was a problem hiding this comment.
Excellent! Could you add a changelog entry too?
seantking
approved these changes
Mar 31, 2022
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
…com:cosmos/ibc-go into damian/1194-add-updatestate-to-cs-interface
seunlanlege
pushed a commit
to ComposableFi/ibc-go
that referenced
this pull request
Aug 9, 2022
* adding UpdateState to ClientState interface and updating surrounds * updating godoc * adding changelog entry * Update modules/core/exported/client.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * fixing typo in changelog Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
CosmosCar
pushed a commit
to caelus-labs/ibc-go
that referenced
this pull request
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UpdateStatetoClientStateinterfacecloses: #1194
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes