Merged
Conversation
faddat
requested review from
AdityaSripal,
charleenfei,
colin-axner,
crodriguezvega,
damiannolan,
fedekunze and
seantking
as code owners
seantking
approved these changes
May 4, 2022
Contributor
seantking
left a comment
seantking
left a comment
There was a problem hiding this comment.
Makes sense to me =) No harm in a little spring cleaning!
crodriguezvega
approved these changes
May 9, 2022
Contributor
crodriguezvega
left a comment
crodriguezvega
left a comment
There was a problem hiding this comment.
Nice cleanup. Thanks, @faddat!
colin-axner
reviewed
May 10, 2022
Contributor
colin-axner
left a comment
colin-axner
left a comment
There was a problem hiding this comment.
LGTM, always nice to do some cleanup 🧹 - thanks for doing this!
see comment on read/write access to simd testnet command
Contributor
Author
|
The write path formatting stuff can be explained here: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1335 +/- ##
==========================================
- Coverage 80.37% 80.34% -0.03%
==========================================
Files 166 166
Lines 12099 12081 -18
==========================================
- Hits 9724 9707 -17
+ Misses 1919 1918 -1
Partials 456 456
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
go install mvdan.cc/gofumpt@latest
gofumpt -w -l .
^ really makes the code look great!
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes