fix: assert previous channel identifer is empty in Msg ValidateBasic by colin-axner · Pull Request #1792 · cosmos/ibc-go

colin-axner · 2022-07-27T12:07:48Z

Description

closes: #1778

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

…annel id to be empty

colin-axner · 2022-07-27T12:10:50Z

modules/core/04-channel/types/msgs_test.go

-		{"too short channel id", types.NewMsgChannelOpenTry(portid, invalidShortChannel, version, types.ORDERED, connHops, cpportid, cpchanid, version, suite.proof, height, addr), false},
-		{"too long channel id", types.NewMsgChannelOpenTry(portid, invalidLongChannel, version, types.ORDERED, connHops, cpportid, cpchanid, version, suite.proof, height, addr), false},
-		{"channel id contains non-alpha", types.NewMsgChannelOpenTry(portid, invalidChannel, version, types.ORDERED, connHops, cpportid, cpchanid, version, suite.proof, height, addr), false},


removed these three cases

colin-axner · 2022-07-27T12:11:06Z

modules/core/04-channel/types/msgs_test.go

+		{"invalid counterparty channel id", types.NewMsgChannelOpenTry(portid, version, types.UNORDERED, connHops, cpportid, invalidChannel, version, suite.proof, height, addr), false},
+		{"empty proof", types.NewMsgChannelOpenTry(portid, version, types.UNORDERED, connHops, cpportid, cpchanid, version, emptyProof, height, addr), false},
+		{"channel not in TRYOPEN state", &types.MsgChannelOpenTry{portid, "", initChannel, version, suite.proof, height, addr}, false},
+		{"previous channel id is not empty", &types.MsgChannelOpenTry{portid, chanid, initChannel, version, suite.proof, height, addr}, false},


added this test case

codecov-commenter · 2022-07-27T12:29:31Z

Codecov Report

Merging #1792 (cacd1b4) into main (88e4388) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1792      +/-   ##
==========================================
- Coverage   79.92%   79.92%   -0.01%     
==========================================
  Files         166      166              
  Lines       12439    12437       -2     
==========================================
- Hits         9942     9940       -2     
  Misses       2030     2030              
  Partials      467      467

Impacted Files	Coverage Δ
modules/core/04-channel/types/msgs.go	`77.09% <100.00%> (-0.15%)`	⬇️

damiannolan

Nice work!

CHANGELOG.md

crodriguezvega

Thanks, @colin-axner!

docs/migrations/v3-to-v4.md

CHANGELOG.md

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

…1792) * remove previous channel id from NewMsgChanOpenTry, assert previous channel id to be empty * add changelog entry * move changelog entry to correct location * add migration docs * Update docs/migrations/v3-to-v4.md Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * Update CHANGELOG.md Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 4a781e5) # Conflicts: # CHANGELOG.md

…(backport #1792) (#1827) * fix: assert previous channel identifer is empty in Msg ValidateBasic (#1792) * remove previous channel id from NewMsgChanOpenTry, assert previous channel id to be empty * add changelog entry * move changelog entry to correct location * add migration docs * Update docs/migrations/v3-to-v4.md Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * Update CHANGELOG.md Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 4a781e5) # Conflicts: # CHANGELOG.md * fix conflicts Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

…(backport cosmos#1792) (cosmos#1827) * fix: assert previous channel identifer is empty in Msg ValidateBasic (cosmos#1792) * remove previous channel id from NewMsgChanOpenTry, assert previous channel id to be empty * add changelog entry * move changelog entry to correct location * add migration docs * Update docs/migrations/v3-to-v4.md Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * Update CHANGELOG.md Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 4a781e5) # Conflicts: # CHANGELOG.md * fix conflicts Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

remove previous channel id from NewMsgChanOpenTry, assert previous ch…

570a562

…annel id to be empty

colin-axner requested review from AdityaSripal, charleenfei, chatton, crodriguezvega, damiannolan and seantking as code owners July 27, 2022 12:07

colin-axner changed the title ~~fix: Assert previous channel identifer is empty in Msg ValidateBasic~~ fix: ssert previous channel identifer is empty in Msg ValidateBasic Jul 27, 2022

colin-axner changed the title ~~fix: ssert previous channel identifer is empty in Msg ValidateBasic~~ fix: assert previous channel identifer is empty in Msg ValidateBasic Jul 27, 2022

add changelog entry

3891be4

colin-axner added the backport-to-v4.0.x label Jul 27, 2022

colin-axner commented Jul 27, 2022

View reviewed changes

colin-axner added 2 commits July 27, 2022 16:18

move changelog entry to correct location

9a440e5

Merge branch 'main' into colin/1778-04channel-leftover

a92162e

damiannolan approved these changes Jul 27, 2022

View reviewed changes

crodriguezvega reviewed Jul 28, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

crodriguezvega mentioned this pull request Jul 28, 2022

fix: assert previous connection id to be empty #1797

Merged

9 tasks

colin-axner added 2 commits July 28, 2022 11:38

add migration docs

ddba6db

merge main

780f0a5

crodriguezvega approved these changes Jul 28, 2022

View reviewed changes

crodriguezvega reviewed Jul 28, 2022

View reviewed changes

docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved

crodriguezvega reviewed Jul 28, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

colin-axner and others added 3 commits July 28, 2022 18:16

Update docs/migrations/v3-to-v4.md

ba6394b

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

Update CHANGELOG.md

23ee894

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

Merge branch 'main' into colin/1778-04channel-leftover

cacd1b4

colin-axner merged commit 4a781e5 into main Jul 28, 2022

colin-axner deleted the colin/1778-04channel-leftover branch July 28, 2022 18:36

mergify bot mentioned this pull request Jul 28, 2022

fix: assert previous channel identifer is empty in Msg ValidateBasic (backport #1792) #1827

Merged

ulbqb mentioned this pull request Jul 31, 2023

Bump up to v4.3.1 Finschia/ibc-go#19

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: assert previous channel identifer is empty in Msg ValidateBasic#1792

fix: assert previous channel identifer is empty in Msg ValidateBasic#1792
colin-axner merged 9 commits intomainfrom
colin/1778-04channel-leftover

colin-axner commented Jul 27, 2022 •

edited

Loading

Uh oh!

colin-axner Jul 27, 2022

Uh oh!

colin-axner Jul 27, 2022

Uh oh!

codecov-commenter commented Jul 27, 2022 •

edited

Loading

Uh oh!

damiannolan left a comment

Uh oh!

Uh oh!

crodriguezvega left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

colin-axner commented Jul 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

colin-axner Jul 27, 2022

Choose a reason for hiding this comment

Uh oh!

colin-axner Jul 27, 2022

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Jul 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

damiannolan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

crodriguezvega left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

colin-axner commented Jul 27, 2022 •

edited

Loading

codecov-commenter commented Jul 27, 2022 •

edited

Loading