chore: remove error return in IterateConsensusStateAscending#1896
Merged
damiannolan merged 3 commits intoupdated-02-client-refactorfrom Aug 8, 2022
Merged
Conversation
damiannolan
requested review from
AdityaSripal,
colin-axner and
seantking
as code owners
Codecov Report
@@ Coverage Diff @@
## updated-02-client-refactor #1896 +/- ##
==============================================================
+ Coverage 80.02% 80.08% +0.05%
==============================================================
Files 167 167
Lines 11759 11753 -6
==============================================================
+ Hits 9410 9412 +2
+ Misses 1931 1925 -6
+ Partials 418 416 -2
|
crodriguezvega
approved these changes
Aug 7, 2022
colin-axner
approved these changes
Aug 8, 2022
Contributor
colin-axner
left a comment
colin-axner
left a comment
There was a problem hiding this comment.
LGTM, thanks! Should we add a changelog?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IterateConsensusStateAscendingcloses: #1886
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes