updated error calls with module names#2399
Conversation
|
Will update the code to fix for issue raised by @colin-axner
|
|
I have mentioned both the portID & channelID in channel callback errors for better identification, lmk if that works |
…el-callback-errors
…el-callback-errors
colin-axner
left a comment
There was a problem hiding this comment.
Thanks @alizahidraja for following up on my suggestion. I think this should help make the error message a bit more useful. Just left a minor suggestion on the error string formatting, but I don't have a strong preference here
…el-callback-errors
…el-callback-errors
…el-callback-errors
damiannolan
left a comment
There was a problem hiding this comment.
Thanks @alizahidraja! LGTM 🚀
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
…el-callback-errors
…el-callback-errors
## Description Included Module names in channel callback errors closes: #1728 --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) (does not apply) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) (does not apply) - [x] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [x] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [x] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit 363970e)
## Description Included Module names in channel callback errors closes: #1728 --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) (does not apply) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) (does not apply) - [x] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [x] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [x] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit 363970e) Co-authored-by: Ali Zahid Raja <alizahidrajaa@gmail.com>
Description
Included Module names in channel callback errors
closes: #1728
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/) (does not apply)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes