chore: update tests to use new SendPacket API#2567
Merged
crodriguezvega merged 7 commits intomainfrom Oct 25, 2022
Merged
Conversation
crodriguezvega
requested review from
AdityaSripal,
charleenfei,
chatton,
colin-axner,
damiannolan and
seantking
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2567 +/- ##
==========================================
+ Coverage 78.74% 78.76% +0.02%
==========================================
Files 178 178
Lines 12298 12298
==========================================
+ Hits 9684 9687 +3
+ Misses 2190 2188 -2
+ Partials 424 423 -1
|
colin-axner
reviewed
Oct 24, 2022
colin-axner
approved these changes
Oct 25, 2022
Contributor
colin-axner
left a comment
colin-axner
left a comment
There was a problem hiding this comment.
Nice work! Thanks @crodriguezvega 🙌
…-new-sendpacket-api
damiannolan
approved these changes
Oct 25, 2022
…-new-sendpacket-api
crodriguezvega
deleted the
carlos/#2452-ibc-testing-endpoint-should-use-new-sendpacket-api
branch
mergify bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
* chore: update tests to use new SendPacket API * add changelog * remove source port and source channel from parameter list of SendPacket Co-authored-by: Carlos Rodriguez <crodveg@gmail.com> (cherry picked from commit 8ce603d) # Conflicts: # modules/core/ante/ante_test.go # modules/light-clients/07-tendermint/client_state_test.go
crodriguezvega
added a commit
that referenced
this pull request
Nov 2, 2022
* chore: update tests to use new SendPacket API (#2567) * chore: update tests to use new SendPacket API * add changelog * remove source port and source channel from parameter list of SendPacket Co-authored-by: Carlos Rodriguez <crodveg@gmail.com> (cherry picked from commit 8ce603d) # Conflicts: # modules/core/ante/ante_test.go # modules/light-clients/07-tendermint/client_state_test.go * fix conflicts * fix merge conflict * fixing conflicts * alignment * alignment * delete file * review comment Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
9 tasks
20 tasks
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #2452
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes