chore: use fully qualified typeURL interface names in protos#3165
Merged
crodriguezvega merged 2 commits intomainfrom Feb 21, 2023
Merged
chore: use fully qualified typeURL interface names in protos#3165crodriguezvega merged 2 commits intomainfrom
crodriguezvega merged 2 commits intomainfrom
Conversation
crodriguezvega
requested review from
AdityaSripal,
charleenfei,
chatton,
colin-axner and
damiannolan
as code owners
colin-axner
approved these changes
Feb 20, 2023
Contributor
colin-axner
left a comment
colin-axner
left a comment
There was a problem hiding this comment.
Nice! Do we need manual changelog entries still?
Contributor
Author
No need now. But we still have some evaluation to do about the process for changelog generation after we do the next tag. |
crodriguezvega
deleted the
carlos/2977-clean-up-acceptimplement_interface
branch
mergify bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
(cherry picked from commit bd053b2)
colin-axner
pushed a commit
that referenced
this pull request
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #2977
Commit Message / Changelog Entry
chore: use fully qualified typeURL interface names in protossee the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.