Skip to content

fix: remove api break from SDK v0.47 bump#3297

Merged
colin-axner merged 1 commit intocarlos/bump-sdk-v0.47from
colin/remove-api-break
Mar 15, 2023
Merged

fix: remove api break from SDK v0.47 bump#3297
colin-axner merged 1 commit intocarlos/bump-sdk-v0.47from
colin/remove-api-break

Conversation

@colin-axner
Copy link
Copy Markdown
Contributor

Description

I think it makes sense to avoid API breaking change in our rc to final release. If we want to break API, we can do that in v8

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Copy Markdown
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM makes sense, we can add this back in v8

@colin-axner colin-axner merged commit 2b202cc into carlos/bump-sdk-v0.47 Mar 15, 2023
@colin-axner colin-axner deleted the colin/remove-api-break branch March 15, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants