fix: remove api break from SDK v0.47 bump#3297
Merged
colin-axner merged 1 commit intocarlos/bump-sdk-v0.47from Mar 15, 2023
Merged
fix: remove api break from SDK v0.47 bump#3297colin-axner merged 1 commit intocarlos/bump-sdk-v0.47from
colin-axner merged 1 commit intocarlos/bump-sdk-v0.47from
Conversation
chatton
approved these changes
Mar 15, 2023
Contributor
chatton
left a comment
There was a problem hiding this comment.
LGTM makes sense, we can add this back in v8
damiannolan
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I think it makes sense to avoid API breaking change in our rc to final release. If we want to break API, we can do that in v8
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.